Repository navigation
feat(user-agent): rename the client to socket-python-cli - #320
Conversation
lelia
left a comment
lelia
left a comment
There was a problem hiding this comment.
John-David Dalton (@jdalton) thanks for adding this, but I think we need to implement backend changes first before we rename on the client side.
I confirmed that backend attribution currently matches user-agents on exact, case sensitive prefixes, and currently only SocketPythonCLI/ is registered, meaning that this rename will cause us to silently lose Python CLI attribution as users upgrade.
By the way, the same class of change needs to take place on the SDK side, too - in fact, the SocketSDKPython/ user-agent appears to have never been registered on the backend. We may as well fix the gap everywhere in one go, if you're up for it.
d79c264 to
a4cc539
Compare
This comment was marked as outdated.
This comment was marked as outdated.
GitHub Actions
Active
c77895c to
a2e8bc6
Compare
GitHub Actions
Active
Use one client name for CLI and SDK requests. Preserve the current release version and record the change under Unreleased.
a2e8bc6 to
ffcc07b
Compare
|
The backend now recognizes both CLI prefixes and |
Backend support for both CLI names and the SDK name has landed. The branch is refreshed and CI passes. Requesting a fresh review.
Merge current main, preserve the 2.11.11 Coana release notes, and use the lowercase CLI identity for direct and SDK calls. Verify both request paths at the HTTP transport boundary. Assisted-by: Codex:GPT-6
There was a problem hiding this comment.
[agent] Refreshed this PR onto current main and resolved the merge conflicts. The User-Agent change is included in 2.11.11; the runtime version, pyproject.toml, and uv.lock all agree, and the existing Coana release notes are preserved. All 584 unit tests passed, including prepared-request coverage for both direct API calls and SDK calls. Ruff and the locked dependency check also passed.
Backend deployment evidence: I verified that the depscan change accepting both SocketPythonCLI/ and socket-python-cli/ as py-cli was confirmed deployed. The CLI rename therefore has no dependency on the upcoming SDK/Basics attribution rollout (TBD).
The SDK dependency bump remains pending selection of the target version; this PR currently retains socketdev==3.6.1. After that update, rerun CI before tagging v2.11.11.
Pin the published SDK and refresh its locked artifacts. Include the upgrade in the 2.11.11 release notes. Assisted-by: Codex:GPT-6
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Use one lowercase
socket-python-cliUser-Agent name across direct API requests and requests the CLI sends through the Python SDK, so attribution stays consistent. Pin the published Python SDK (socketdev) to3.6.2, which rejects retired API credentials before use.The backend accepts both
SocketPythonCLI/andsocket-python-cli/aspy-cli, and that support is deployed. This CLI rename can ship independently of the later standalone SDK/Basics attribution work.Both changes are included in
2.11.11. The changelog and package-constant merge conflicts are resolved, and the existing Coana 15.14.1 release notes are preserved.Validation
uv.lock, using the published SDK3.6.2. Prepared-request regression coverage verifies the lowercase CLI identity on both direct and SDK calls.pyproject.toml, anduv.lockall agree on2.11.11.uv lock --locked --offline, repository-wide Ruff, the CI import smoke check, andgit diff --checkpassed.socketdev==3.6.2with hashes. The lockfile update changes only the SDK artifacts and the project's SDK requirement; other package versions are preserved.Release readiness
SDK
3.6.2is published and pinned; no SDK version selection remains outstanding. Backend compatibility is already deployed. Merge after the required review approval and CI checks for the latest commit pass, then tagv2.11.11for release.